rename go.mod1 to go.mod#682
Merged
kennytm merged 3 commits intopingcap:masterfrom Dec 16, 2019
Merged
Conversation
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
=======================================
Coverage 79.82% 79.82%
=======================================
Files 37 37
Lines 13596 13596
=======================================
Hits 10853 10853
Misses 2100 2100
Partials 643 643Continue to review full report at Codecov.
|
kennytm
reviewed
Dec 16, 2019
Contributor
kennytm
left a comment
kennytm
left a comment
There was a problem hiding this comment.
LGTM.
(We should remove logrus someday)
Collaborator
|
LGTM |
tiancaiamao
approved these changes
Dec 16, 2019
tiancaiamao
approved these changes
Dec 16, 2019
Contributor
|
(Broken CLA) |
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
* rename go.mod1 to go.mod * update .gitignore * downgrade logrus
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
* rename go.mod1 to go.mod * update .gitignore * downgrade logrus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Make parser as a go module.
What is changed and how it works?
Rename go.mod1 to go.mod.
Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes
N/A